Skip to content

Rewrite loader #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 6, 2019
Merged

Rewrite loader #537

merged 16 commits into from
Jan 6, 2019

Conversation

wzrdtales
Copy link
Member

@wzrdtales wzrdtales commented Feb 2, 2018 •
edited
Loading

Implementation Details

  • Walker gets file
  • Walker evaluates file version
  • Walker calls correct executor (static/versioned + version number)
  • Executor calls the migration with its underlying logic that needs to be fullfilled

Refactoring

  • Removing all specific files: skeleton, seed, seeder, migration, migrator
  • Adding temporarily temputils for helpers that we're going to move into an own module or db-migrate-shared
  • Cut conenction between createMigration and connect.js
  • Move templating into new temporary location

Bugfixes on the way

  • Fix context of executionUnits

Refers to #215

@ghost
Copy link

ghost commented Feb 2, 2018

There were the following issues with this Pull Request

  • Commit: d5231a3
    • ✖ body must have leading blank line
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding!

@ghost
Copy link

ghost commented Feb 2, 2018

There were the following issues with this Pull Request

  • Commit: 879b1fa
    • ✖ body must have leading blank line

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding!

@wzrdtales wzrdtales force-pushed the rewriteLoader branch 2 times, most recently from d3e563d to 2fb3afa Compare February 2, 2018 15:34
@wzrdtales wzrdtales self-assigned this Feb 2, 2018
@wzrdtales wzrdtales added this to the v0.11.0 milestone Feb 2, 2018
@ghost
Copy link

ghost commented Feb 3, 2018

There were the following issues with this Pull Request

  • Commit: 626a58b
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding!

@ghost
Copy link

ghost commented Feb 3, 2018

There were the following issues with this Pull Request

  • Commit: 25b458c
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding!

@wzrdtales
Copy link
Member Author

🎉 Rewrite of this part is done. If you want you can checkout @BorntraegerMarc , I'm next targeting the state manager as dependency to the version 2 schema that is following after this.

@wzrdtales wzrdtales mentioned this pull request Mar 27, 2018
Closed
@wzrdtales wzrdtales mentioned this pull request Apr 5, 2018
Open
4 tasks
wzrdtales added 11 commits April 10, 2018 20:29
@wzrdtales
refactor(files): First write down of the walker and separating file API
24017bb 
Refers to #215

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor(files): some more changes to file, walker as well as the
349fb7b 
start of the port of the version 1 schema.

Refers to #215

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor(executor): use file api
89c6ec3 
Referst to #215

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
fix(walker): rename interface to Interface
6234d42 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor(loader): functioning loader
90038fc 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
fix(utils): resolve when returned null
68361fe 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
fix(scope): new scoping errored out when using templates
b2421e3 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor: adding down and sync to user walker and apply patches
657ebe2 
patched to make sync and down working properly.

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor: differenciate between modes and add seeds
35b956e 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor: prepare removal and adjust hooks and deprecate
141d509 
Deprecate old hook 'migrator:migration:hook:require' and add a
warning.
Prepare to finally remove all other unnecessary files.

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
refactor: restore node v4 support
e7099b8 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
Copy link
Member Author

incorporate #552

@wzrdtales
Copy link
Member Author

rebased, rewriting logic of #552 to new loader

@wzrdtales
chore: refactor check to new loader
dd0e507 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
chore: return array of files correctly on check
6144472 
Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales
fix(reset): regression introduced in check functionality
61ca5bb 
#552 introduced a regression and effectively disfunctioned the reset function, since it
did append just to the actionables within the run context.

It was moved into its own context.

Signed-off-by: Tobias Gurtzick <[email protected]>
@wzrdtales wzrdtales merged commit d53369d into master Jan 6, 2019
@wzrdtales wzrdtales deleted the rewriteLoader branch January 6, 2019 11:40
@wzrdtales wzrdtales mentioned this pull request Jun 1, 2019
Open
18 tasks
@genslein genslein mentioned this pull request Jun 21, 2023
Open
@christian-heath christian-heath mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wzrdtales wzrdtales

Labels

BREAKING CHANGES feature Refactoring

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

1 participant

@wzrdtales